A hydraulic transmission comprising a variable displacement pump and motor, at least one having cylinders having valves which are controllable on each cycle of cylinder working volume to determine the net displacement of working fluid by the cylinder. The transmission has a valve control module which determines a displacement of the pump and the motor by specifying a displacement demand. The pump and/or motor valve control module determine the frequency of intensity peaks in the frequency spectrum of the pattern of cylinders carrying out active and inactive cycles of cylinder working volume using a first procedure and, if these will fall within disallowed frequency bands including the resonant frequency of components with which the transmission is in mechanical communication, the displacement demand, or another input, is periodically modified to suppress generation of those frequencies. The hydraulic transmission is useful for example in a wind turbine generator, or a vehicle.